[PATCH] fix build warnings for functions without return value

Dave Korn dave.korn.cygwin@gmail.com
Thu Jul 29 02:39:00 GMT 2010


On 29/07/2010 00:19, Daniel Colascione wrote:
>> From: cygwin-patches-owner@cygwin.com [mailto:cygwin-patches-
>>
>> I don't see why this is needed.  Cygwin uses -Werror by default so, if gcc
> 4.3.4
>> emitted warnings we wouldn't be able to build a release or make a
> snapshot.
> 
> It's because Cygwin uses -Werror that I had to patch the source. I'm
> compiling with '-Os -march=native', which must tickle a different part of
> the optimizer and thereby produce this warning.

  This is http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42674

> (One of the nice things
> about clang is reportedly that it produces the same warnings no matter what
> the optimizer does.) Besides, the current code is technically undefined and
> the patch removes that undefined behavior --- which could start producing
> warnings for the current build at any time.

  I think actually it's not undefined, because the functions never return.

    cheers,
      DaveK



More information about the Cygwin-patches mailing list