[PATCH 3/4] dlopen: on x/lib search x/bin if exe is in x/bin

Michael Haubenwallner michael.haubenwallner@ssi-schaefer.com
Fri Sep 2 11:57:00 GMT 2016


On 09/02/2016 11:03 AM, Corinna Vinschen wrote:
> On Sep  2 10:46, Michael Haubenwallner wrote:
>> On 09/01/2016 03:32 PM, Corinna Vinschen wrote:
>>> You could just use the global variable program_invocation_name.  If in
>>> doubt, use the Windows path global_progname and convert it to full POSIX
>>> via cygwin_conv_path.
>>
>> Patch updated, using global_progname now.
> 
> Looks good and you're right to do it this way since I just noticed
> that program_invocation_name may return a relative pathname.

Yep.

> Btw., in other calls which require the full POSIX path we use
> mount_table->conv_to_posix_path instead of cygwin_conv_path (see
> e. g. fillout_pinfo()).  It's a bit faster.  Maybe something for a 
> followup patch.

No problem - attached.
This renders the original patch 4/4 valid again.

> Note for some later improvement:  I really wonder why we don't store
> the absolute POSIX path of the current executable globally yet...

Same here.

Thanks!
/haubi/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-dlopen-on-x-lib-search-x-bin-if-exe-is-in-x-bin.patch
Type: text/x-patch
Size: 3080 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20160902/6bc68f60/attachment.bin>


More information about the Cygwin-patches mailing list