[PATCH 00/11] More testsuite fixes

Jon Turney jon.turney@dronecode.org.uk
Thu Jul 13 11:38:53 GMT 2023


This gets us from :

FAIL: cygload
FAIL: devdsp.c
FAIL: ltp/access05.c
FAIL: ltp/fcntl07.c
FAIL: ltp/symlink01.c
FAIL: ltp/symlink03.c
FAIL: ltp/umask03.c
FAIL: pthread/cancel11.c
FAIL: pthread/cancel3.c
FAIL: pthread/cancel5.c
FAIL: pthread/inherit1.c
FAIL: pthread/priority1.c
FAIL: pthread/priority2.c
FAIL: systemcall.c

to:

FAIL: cygload
FAIL: devdsp.c
FAIL: ltp/umask03.c
FAIL: pthread/cancel11.c
FAIL: pthread/priority1.c

Notes on the remaining failures:

cygload: I have no idea of the voodoo needed to make this work

devdsp: forkplaytest() is broken in some complex way I don't understand, causing a hang. It looks like the child 
process doesn't exit, which must be a bug in Cygwin?

devdsp: it's totally unclear to me if opening /dev/dsp twice is meant to be allowed or not

umask03: was utterly broken, now fails, but accurately reports the failure. I don't quite understand the 
permissions issue which is causing it to fail.

cancel11: some funkiness I can't work out, causing the save/restoring signal handlers around system() to not 
work correctly

priority1: this looks like a bug with pthread_create() and a non-null pthread_attr_t *, for which I'll send a 
patch shortly.

Jon Turney (11):
  Cygwin: testsuite: Setup test prereqs in 'installation' the tests run
    in
  Cygwin: testsuite: Add a simple timeout mechanism
  Cygwin: testsuite: Remove const from writable string in fcntl07b
  Cygwin: testsuite: Skip devdsp test when no audio devices present
  Cygwin: testsuite: Just log result of second open of /dev/dsp
  Cygwin: testsuite: Also check direct call in systemcall
  Cygwin: testsuite: Fix for limited thread priority values
  Cygwin: testsuite: Busy-wait in cancel3 and cancel5
  Cygwin: testsuite: Fix a buffer overflow in symlink01
  Cygwin: testsuite: Minor fixes to umask03
  Cygwin: testsuite: Drop Adminstrator privileges while running tests

 .github/workflows/cygwin.yml                  |  4 ++-
 winsup/cygwin/Makefile.am                     |  4 +--
 winsup/doc/faq-programming.xml                |  4 ++-
 winsup/testsuite/Makefile.am                  | 28 ++++++++++++++-
 winsup/testsuite/cygrun.c                     | 17 +++++++--
 winsup/testsuite/winsup.api/devdsp.c          | 35 +++++++++++--------
 winsup/testsuite/winsup.api/ltp/fcntl07B.c    |  2 +-
 winsup/testsuite/winsup.api/ltp/symlink01.c   |  2 +-
 winsup/testsuite/winsup.api/ltp/umask03.c     | 21 ++++++-----
 winsup/testsuite/winsup.api/pthread/cancel3.c | 24 +++++++++----
 winsup/testsuite/winsup.api/pthread/cancel5.c | 24 +++++++++----
 .../testsuite/winsup.api/pthread/inherit1.c   | 21 ++++++++++-
 .../testsuite/winsup.api/pthread/priority1.c  | 24 +++++++++++--
 .../testsuite/winsup.api/pthread/priority2.c  | 22 ++++++++++--
 winsup/testsuite/winsup.api/systemcall.c      | 10 +++++-
 winsup/testsuite/winsup.api/winsup.exp        |  2 +-
 16 files changed, 194 insertions(+), 50 deletions(-)

-- 
2.39.0



More information about the Cygwin-patches mailing list